yashmayya commented on code in PR #18550: URL: https://github.com/apache/pinot/pull/18550#discussion_r3278637985
########## docker/images/pinot/etc/jmx_prometheus_javaagent/configs/broker.yml: ########## @@ -34,7 +34,8 @@ rules: - pattern: "\"org\\.apache\\.pinot\\.common\\.metrics\"<type=\"BrokerMetrics\", name=\"pinot\\.broker\\.(uncaughtGet|uncaughtPost|queryRejected|requestCompilation|resourceMissing)Exceptions\"><>(\\w+)" name: "pinot_broker_exceptions_$1_$2" cache: true -# All global gauge/meters/timers -- pattern: "\"?org\\.apache\\.pinot\\.common\\.metrics\"?<type=\"?\\w+\"?, name=\"?pinot\\.broker\\.(\\w+)\"?><>(\\w+)" - name: "pinot_broker_$1_$2" +# All global gauge/meters/timers. Group-flexible at the prefix so non-broker MBean groups +# registered in this JVM (e.g. pinot.mse.* from the multi-stage engine emitter) are also exported. +- pattern: "\"?org\\.apache\\.pinot\\.common\\.metrics\"?<type=\"?\\w+\"?, name=\"?pinot\\.(\\w+)\\.(\\w+)\"?><>(\\w+)" Review Comment: The server Prometheus agent config already had this flexible regex. The unit tests verify that the new `pinot.mse*` metrics get captured on the server side as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
