xiangfu0 commented on code in PR #18530:
URL: https://github.com/apache/pinot/pull/18530#discussion_r3289109514
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/utils/SegmentPushUtilsTest.java:
##########
@@ -83,6 +86,20 @@ public void testSegmentParallelProtectionUploadParam() {
Assert.assertEquals(nameValuePair.getValue(), "true");
}
+ @Test
+ public void testGetFileUploadDownloadClientHonorsTlsSpec()
+ throws Exception {
+ SegmentGenerationJobSpec defaultJobSpec = new SegmentGenerationJobSpec();
+ FileUploadDownloadClient defaultClient =
SegmentPushUtils.getFileUploadDownloadClient(defaultJobSpec);
+ assertSame(SegmentPushUtils.getFileUploadDownloadClient(defaultJobSpec),
defaultClient);
+
+ SegmentGenerationJobSpec tlsJobSpec = new SegmentGenerationJobSpec();
+ tlsJobSpec.setTlsSpec(new TlsSpec());
Review Comment:
This test doesn't test anything ;)
You need to add a test with a custom truststore/keystore, ideally against a
local HTTPS endpoint that fails with the default client and succeeds through
SegmentPushUtils with TlsSpec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
