rseetham commented on code in PR #18560:
URL: https://github.com/apache/pinot/pull/18560#discussion_r3291391537
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/PartitionGroupMetadataFetcher.java:
##########
@@ -152,9 +158,11 @@ private Boolean fetchMultipleStreams()
_exception = e;
return Boolean.FALSE;
} catch (Exception e) {
- LOGGER.warn("Could not get StreamMetadata for topic {}", topicName, e);
- _exception = e;
- throw e;
+ // In a multi-topic table, a single inaccessible topic (e.g. deleted
from Kafka) must not
+ // block metadata fetching for the remaining healthy topics. Log and
skip — the successful
+ // topics are already in _streamMetadataList and will be returned to
the caller.
+ LOGGER.warn("Could not get StreamMetadata for topic {}, skipping in
multi-topic fetch", topicName, e);
Review Comment:
Makes sense. I changed it so it only skips adding it if we discover that the
topic is missing. org.apache.kafka.clients.admin.AdminClient is used to figure
out if the topic exists or not in Kafka.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
