tarun11Mavani commented on code in PR #18368:
URL: https://github.com/apache/pinot/pull/18368#discussion_r3305024906


##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/ComplexFieldSpec.java:
##########
@@ -58,17 +61,45 @@ public final class ComplexFieldSpec extends FieldSpec {
 
   private final Map<String, FieldSpec> _childFieldSpecs;
 
-  // Default constructor required by JSON de-serializer
-  public ComplexFieldSpec() {
+  @Nullable
+  private final Map<String, FieldSpec> _valueFieldSpecs;

Review Comment:
   Reused _childFieldSpecs in `OPEN_STRUCT`.
   
   We now introduce a new OPEN_STRUCT data type to host the semi-structured 
semantics (open string-keyed shape with per-key value typing), restoring 
DataType.MAP to its original typed-map definition (uniform key and value 
types). The columnar storage backend now hosts OPEN_STRUCT, not MAP. See "What 
changed since last revision" below.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to