rseetham commented on code in PR #17669:
URL: https://github.com/apache/pinot/pull/17669#discussion_r3306656225
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/PartitionGroupMetadataFetcher.java:
##########
@@ -102,6 +105,11 @@ private Boolean fetchSingleStream()
private Boolean fetchMultipleStreams()
throws Exception {
int numStreams = _streamConfigs.size();
+
+ // For multi topic tables - Fetch available topics once and reuse across
all streams
+ // (for topic existence validation)
+ Set<String> availableTopicNames = fetchAvailableTopicNames();
Review Comment:
I have a change to clean up this just this PartitionGroupMetadataFetcher
failure which I think does this cleaner:
https://github.com/apache/pinot/pull/18560
You're doing
`try (StreamMetadataProvider provider =
factory.createStreamMetadataProvider(clientId))`
fetch twice as it's written now in the happy case, once to find available
topic and once for the actual fetch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
