KKcorps commented on code in PR #18581:
URL: https://github.com/apache/pinot/pull/18581#discussion_r3316155939
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/helix/ZkMultiWriteBuilder.java:
##########
@@ -152,12 +157,52 @@ public void execute()
} catch (ZkException ze) {
Throwable cause = ze.getCause();
if (cause instanceof KeeperException) {
- throw (KeeperException) cause;
+ KeeperException ke = (KeeperException) cause;
+ logFailedOps(ke);
+ throw ke;
}
throw ze;
}
}
+ private void logFailedOps(KeeperException e) {
+ List<OpResult> results = e.getResults();
+ if (results == null) {
+ LOGGER.warn("ZK multi-op error has no per-op results attached: {}",
e.toString());
Review Comment:
nit: we can simply pass `e` here right, no need for `e.toString()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
