wolfkill opened a new pull request, #18606: URL: https://github.com/apache/pinot/pull/18606
Fixes #14594. ## Summary - mark the user API `component` query parameter as required for get/delete/update endpoints - reject missing component values with a clear bad request instead of constructing `null` user names or surfacing an NPE - normalize validated component values before update/delete user lookups ## Tests - `JAVA_HOME=/opt/homebrew/opt/openjdk@21/libexec/openjdk.jdk/Contents/Home ./mvnw -pl pinot-controller -am -Dtest=PinotAccessControlUserRestletResourceTest#testGetUserWithoutComponentReturnsClearBadRequest+testUserComponentQueryParamIsRequiredInSwagger -DfailIfNoTests=false -Dsurefire.failIfNoSpecifiedTests=false test` - `JAVA_HOME=/opt/homebrew/opt/openjdk@21/libexec/openjdk.jdk/Contents/Home ./mvnw -pl pinot-controller -am -Dtest=PinotAccessControlUserRestletResourceTest -DfailIfNoTests=false -Dsurefire.failIfNoSpecifiedTests=false test` - `git diff --check` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
