wolfkill opened a new pull request, #18610:
URL: https://github.com/apache/pinot/pull/18610
Fixes #9987.
When a selected znode disappears before the browser expands it, the
controller can return a 404 payload such as `{ code, error }` from `/zk/lsl`.
The browser currently iterates every key in that payload and renders `code` and
`error` as child znodes.
This change only turns entries with a valid ZooKeeper stat shape into tree
children, so missing-node responses leave the expanded node with no fake
children while real children named `code` or `error` are still preserved when
their values are stat objects.
Validation:
- `npm run build-dev`
- `npm run build`
- `git diff --check`
- local reproducer for missing-node and real `code`/`error` child payloads
I also ran `npx eslint app/utils/PinotMethodUtils.ts --quiet`; it still
fails on existing repository lint configuration and pre-existing errors
unrelated to this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
