wolfkill opened a new pull request, #18611:
URL: https://github.com/apache/pinot/pull/18611

   ### Summary
   - validate server data directories by creating and deleting a temporary 
probe file
   - keep the existing directory creation and cleanup flow
   - add coverage to ensure the writability check does not leave probe files 
behind
   
   ### Testing
   - `JAVA_HOME=/opt/homebrew/opt/openjdk@21/libexec/openjdk.jdk/Contents/Home 
./mvnw -pl pinot-server -am 
-Dtest=HelixInstanceDataManagerTest#testDirectoryWritabilityCheckDoesNotLeaveProbeFile
 -Dsurefire.failIfNoSpecifiedTests=false test -DskipShade -Dskip.license=true`
   - `JAVA_HOME=/opt/homebrew/opt/openjdk@21/libexec/openjdk.jdk/Contents/Home 
./mvnw -pl pinot-server -am -Dtest=HelixInstanceDataManagerTest 
-Dsurefire.failIfNoSpecifiedTests=false test -DskipShade -Dskip.license=true`
   - `git diff --check`
   
   Addresses #15860


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to