st-omarkhalid commented on code in PR #18602:
URL: https://github.com/apache/pinot/pull/18602#discussion_r3317948178
##########
pinot-common/src/main/java/org/apache/pinot/common/response/BrokerResponse.java:
##########
@@ -449,4 +449,19 @@ default long getRealtimeTotalMemAllocatedBytes() {
default String getMaterializedViewQueried() {
return null;
}
+
+ /// Get the per-server stats string captured during scatter for this query,
or `null` if not
+ /// populated. For single-stage queries served by the Netty
(single-connection) transport the
+ /// value is the formatted string built by
+ /// `org.apache.pinot.core.transport.AsyncQueryResponse#getServerStats()`
(one entry per scattered
+ /// server with submit/response/deserialization timings and response size).
Other transports
+ /// (e.g. gRPC) and multi-stage queries leave this `null` because OSS does
not currently compute a
+ /// per-server stats string on those paths. The default returns `null` so
impls that do not
+ /// track per-server stats (e.g. MSE response paths) need no explicit
override; the matching
+ /// *setter* is deliberately not defaulted here, mirroring the asymmetry
used by
+ /// [#getMaterializedViewQueried] above.
+ @Nullable
+ default String getServerStats() {
+ return null;
+ }
Review Comment:
@gortiz Can you point out which class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
