AlexanderKM opened a new pull request, #18617: URL: https://github.com/apache/pinot/pull/18617
## Summary We run large batch segment uploads and occasionally hit timeout failures because the upload takes longer than the default allows. This PR makes the segment upload timeout configurable via `PushJobSpec` so callers can tune it without touching source code. Two changes: - **`PushJobSpec`**: adds `segmentUploadTimeoutMs` field (defaults to `600_000` ms / 10 min, matching `HttpClient.DEFAULT_SOCKET_TIMEOUT_MS`, so existing behavior is unchanged out of the box). - **`FileUploadDownloadClient`**: changes the `segmentUploadRequestTimeoutMs` parameter on `uploadSegmentMetadataFiles` from `int` to `long` so it can accept the value from `PushJobSpec` without a cast. This is safe — Java widens `int` to `long` automatically, so any existing callers passing an `int` literal or variable continue to compile and work correctly without modification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
