yashmayya commented on PR #18620: URL: https://github.com/apache/pinot/pull/18620#issuecomment-4569235929
Closing this. On reflection, the standard scan path (ProjectPlanNode -> DocIdSetPlanNode -> DocIdSetOperator) already calls QueryThreadContext.sampleUsage() once per block, and group-by / aggregation / distinct / selection all go through it. The projection-level sample fires at essentially the same point in each block iteration (column materialization is lazy, happening later when the executor reads the block), so it adds no freshness over the existing per-block sample on the main path -- it would only backfill the bounded BitmapDocIdSetOperator-fed paths. Not worth the redundancy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
