wolfkill opened a new pull request, #18631: URL: https://github.com/apache/pinot/pull/18631
## Summary - mark the `component` query parameter as required for get, delete, and update User API operations - add a reflection-based test to keep the Swagger contract aligned with the required User API parameter ## Why The User API needs `component` to identify the component-specific user entry. Without this Swagger metadata, the UI can present the field as optional even though the request path requires it. Fixes #14594 ## Tests - RED: `JAVA_HOME=/opt/homebrew/opt/openjdk@21/libexec/openjdk.jdk/Contents/Home ./mvnw -pl pinot-controller -am -Dtest=PinotAccessControlUserRestletResourceSwaggerTest -Dsurefire.failIfNoSpecifiedTests=false test` failed before the annotation change with `component must be marked required on getUser expected [true] but found [false]` - GREEN: `JAVA_HOME=/opt/homebrew/opt/openjdk@21/libexec/openjdk.jdk/Contents/Home ./mvnw -pl pinot-controller -am -Dtest=PinotAccessControlUserRestletResourceSwaggerTest -Dsurefire.failIfNoSpecifiedTests=false test` - `git diff --check` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
