yashmayya commented on PR #18623:
URL: https://github.com/apache/pinot/pull/18623#issuecomment-4577451857
Checked this. Running `mvn verify` twice in a row behaves exactly the same
as master — javacc skips ("all parsers are up to date") and `Parser.jj` isn't
rewritten, so the codegen doesn't cause a recompile. The full recompile you'd
see is just maven-compiler-plugin recompiling every run regardless; that part
is identical with or without this change.
The only real difference vs master: since FMPP now always runs instead of
being gated by the profile, the second build does one extra FMPP pass (~1-2s)
into a staging dir, followed by a content diff that's a no-op when nothing
changed. So it adds that small fixed cost but doesn't trigger any extra
recompilation. Felt like a fair trade to stop `clean install` from breaking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
