timothy-e commented on PR #18636: URL: https://github.com/apache/pinot/pull/18636#issuecomment-4594505297
> This file is kept in sync with https://github.com/prestodb/presto/blob/master/presto-common/src/main/resources/com/facebook/presto/common/type/zone-index.properties. We don't want to add custom timezones into it. We're seeing some errors because users are supplying valid timezones that aren't supported by Pinot, but they are supported by all the relevant libraries. It's hard to tell people "here's an arbitrary subset of timezones that we won't support, subject to change at each release." Maybe the best solution is for me to try pushing this to Presto as well? > Are these added timezones valid in joda? Yeah, I added a test `testAllTimeZonesSupportedByJodaTime` to verify it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
