xiangfu0 commented on PR #18687: URL: https://github.com/apache/pinot/pull/18687#issuecomment-4655084831
Adjusted per latest discussion: the 5-arg `StreamMetadataProvider.computePartitionGroupMetadata(...)` overload is back in the SPI base interface as the shared `forceGetOffsetFromStream` wrapper. Kafka 3.0/4.0, Pulsar, and the fake stream provider no longer duplicate that method; they only implement the provider-specific 4-arg partition mapping. Kinesis keeps its existing 5-arg override because it intentionally ignores the force flag and preserves its current behavior. The Kafka fix remains in the concrete 4-arg methods: fetch upstream partition count, loop `0..partitionCount-1`, key current statuses by `getStreamPartitionGroupId()`, and fetch stream offsets for missing ids. The focused SPI/Kafka/Pulsar reactor passed after this adjustment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
