Akanksha-kedia commented on PR #18491: URL: https://github.com/apache/pinot/pull/18491#issuecomment-4661192317
After rebasing on current master, I found that PR #18484 (merged upstream) already added a comprehensive `hasOnlyRetryableQueryExceptions()` helper that handles this case — and more: it covers `BROKER_INSTANCE_MISSING`, `BROKER_SEGMENT_UNAVAILABLE`, and several other retryable codes via the `RETRYABLE_QUERY_ERROR_CODES` set, and the `getErrorCode()` helper safely handles null errorCode nodes (the original NPE trigger). Our fix is fully superseded. Closing this PR to avoid duplication. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
