xiangfu0 commented on code in PR #18723:
URL: https://github.com/apache/pinot/pull/18723#discussion_r3386420360
##########
pinot-sql-ddl/src/main/java/org/apache/pinot/sql/ddl/compile/DdlCompiler.java:
##########
@@ -110,6 +120,18 @@ public static MaterializedViewDdlHandler
getMaterializedViewDdlHandler() {
return _materializedViewDdlHandler;
}
+ /// Installs the [CreateTableWithOptionsHandler] used for all subsequent
options-defined
+ /// `CREATE TABLE ... WITH (...)` compilations. Call once at controller
startup; defaults to
+ /// [DefaultCreateTableWithOptionsHandler], which rejects the form.
+ public static void
setCreateTableWithOptionsHandler(CreateTableWithOptionsHandler handler) {
+ _createTableWithOptionsHandler = handler;
+ }
Review Comment:
Fixed in 84800dc755: both setters now reject null via Objects.requireNonNull
with a message pointing at the Default*Handler for restoring default behavior,
plus a fail-fast unit test covering both setters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
