Akanksha-kedia commented on code in PR #18514:
URL: https://github.com/apache/pinot/pull/18514#discussion_r3387704948
##########
pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotJoinExchangeNodeInsertRule.java:
##########
@@ -87,6 +87,19 @@ public void onMatch(RelOptRuleCall call) {
// worker, avoiding hotspots.
newLeft = PinotLogicalExchange.create(left,
RelDistributions.hash(Collections.emptyList()));
newRight = PinotLogicalExchange.create(right,
RelDistributions.hash(Collections.emptyList()));
+ } else if
(PinotHintOptions.JoinHintOptions.useBroadcastRightJoinStrategy(join)) {
Review Comment:
Fixed in the latest commit. Added a `Preconditions.checkArgument` guard in
both `PinotJoinExchangeNodeInsertRule` and `TraitAssignment.assignJoin()` that
rejects `RIGHT`/`FULL` outer joins when the `broadcast_right` hint is used,
with a clear error message explaining why (each worker would independently emit
unmatched right rows → duplicate null-extended rows). @xiangfu0 @Jackie-Jiang
could you re-review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
