xiangfu0 commented on PR #18731: URL: https://github.com/apache/pinot/pull/18731#issuecomment-4685296255
Closing this in favor of fixing the root cause in TableRebalancer: the broker-side change only caps the blast radius after segments have already become unservable, and for upsert tables serving the remaining segments of a partition could surface stale values, which is arguably worse than failing loudly. The real issue is that a best-efforts rebalance can advance the IdealState past ExternalView convergence and drop the last actually-serving replica of a segment, leaving it ONLINE nowhere. Will follow up with a TableRebalancer fix that makes the min-available-replicas check ExternalView-aware so this state can never be created. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
