Jackie-Jiang opened a new pull request, #18795: URL: https://github.com/apache/pinot/pull/18795
## Summary Removes Helix **batch message mode** as a configurable feature and hard-disables it everywhere it could be set. **Config surface removed** (`ControllerConf`) - Drops the `controller.enable.batch.message.mode` key, its `DEFAULT_ENABLE_BATCH_MESSAGE_MODE` default, and `getEnableBatchMessageMode()`. The default was already `false`. **Plumbing removed** — the `enableBatchMessageMode` boolean is no longer threaded through cluster/table setup: - `BaseControllerStarter`, `PinotHelixResourceManager` (field + constructor param), `HelixSetupUtils.setupPinotCluster` / `createBrokerResourceIfNeeded` / `createLeadControllerResourceIfNeeded` / `constructIdealState`, and `PinotTableIdealStateBuilder.buildEmptyIdealStateFor`. New IdealStates now default to batch message mode off. **Active enforcement** — batch message mode is stripped wherever an existing IdealState might carry it: - `HelixSetupUtils` disables it on the existing broker and lead-controller resources at controller startup. The broker resource now mirrors the lead-controller handling (previously the existing-resource case was a no-op). - `IdealStateGroupCommit` and `IdealStateSingleCommit` disable it on any IdealState before writing it back to ZooKeeper. Pre-existing per-table segment IdealStates are cleaned lazily on their next update (no eager sweep), which is inert for idle tables since they perform no state transitions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
