Akanksha-kedia commented on code in PR #17584:
URL: https://github.com/apache/pinot/pull/17584#discussion_r3435445118
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/TlsIntegrationTest.java:
##########
@@ -253,6 +253,22 @@ protected void overrideMinionConf(PinotConfiguration
minionConf) {
minionConf.setProperty("pinot.minion.tls.truststore.password", "changeit");
minionConf.setProperty("pinot.minion.tls.truststore.type", "PKCS12");
minionConf.setProperty("pinot.minion.tls.client.auth.enabled", "true");
+
+// // Add segment fetcher and uploader configurations for TLS communication
Review Comment:
The commented-out block was from an older iteration of this PR and has since
been cleaned up. Additionally, the method override has been aligned with the
upstream rename from `getControllerRequestClientHeaders` →
`getAdminClientHeaders` (introduced in #18755) — latest commit updates this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
