Akanksha-kedia commented on code in PR #18778:
URL: https://github.com/apache/pinot/pull/18778#discussion_r3435449499
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -1897,19 +1897,6 @@ private void updateSchema(Schema schema, Schema
oldSchema, boolean forceTableSch
LOGGER.info("Updated schema: {}", schemaName);
}
- /**
- * Delete the given schema.
- * @param schema The schema to be deleted.
- * @return True on success, false otherwise.
- */
- @Deprecated
Review Comment:
Agreed — thank you for the catch. I'll restore `deleteSchema(Schema)`,
`getSchemaForTableConfig(TableConfig)`, and `getServersForSegment(...)` as
delegating stubs so binary compatibility is preserved for callers on released
jars. Will update this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]