davidballano commented on code in PR #18793:
URL: https://github.com/apache/pinot/pull/18793#discussion_r3439298601
##########
helm/pinot/templates/controller/statefulset.yaml:
##########
@@ -65,7 +66,7 @@ spec:
- name: controller
securityContext:
{{- toYaml .Values.controller.securityContext | nindent 10 }}
- image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
+ image: "{{ .Values.minionImage.repository | default
.Values.image.repository }}:{{ .Values.minionImage.tag | default
.Values.image.tag }}"
Review Comment:
Minions and controller are tied together, so controller should know about
new minions to properly schedule them for execution, it's ok to deploy the same
custom image with minions to all components, we just isolated it so we can do
deploy without rolling all servers (servers do not need to know about minion
plugins)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
