Jackie-Jiang opened a new pull request, #18814: URL: https://github.com/apache/pinot/pull/18814
## Summary The `dateTimeConvert` scalar function previously declared its time-value parameter as `String`, forcing every input to be stringified before parsing. This widens the parameter to `Object` and dispatches on the **input** format the same way [DateTimeConversionTransformFunction] does: - `EPOCH` / `TIMESTAMP` input is read as a `LONG`. - `SIMPLE_DATE_FORMAT` input is read as a `STRING`. The input value is coerced to the target type using the same `PinotDataType` conversion as [FunctionInvoker#convertTypes], so numeric columns, numeric strings, and the date-related logical types produced by the `RecordExtractor` contract (`java.sql.Timestamp`, `java.time.LocalDate`, `java.time.LocalTime`) are all accepted for `EPOCH` / `TIMESTAMP` input rather than being forced through a stringify-then-parse round trip. This also drops a dead `_bucketingTimeZone` field that was only ever assigned, never read. Added `testDateTimeConvertRecordExtractorDateTypes` covering the `TIMESTAMP` / `DATE` / `TIME` logical types from the `RecordExtractor` contract. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
