Jackie-Jiang commented on code in PR #18784: URL: https://github.com/apache/pinot/pull/18784#discussion_r3444939319
########## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/ingestion/ServerIngestionOomProtectionConfig.java: ########## @@ -0,0 +1,45 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.config.table.ingestion; + +import com.fasterxml.jackson.annotation.JsonPropertyDescription; +import javax.annotation.Nullable; +import org.apache.pinot.spi.config.BaseJsonConfig; + + +/// Table-level override for server-side realtime ingestion OOM protection. +public class ServerIngestionOomProtectionConfig extends BaseJsonConfig { + public enum Mode { Review Comment: We have a enum `Enablement` for this purpose ########## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ########## @@ -1579,6 +1579,24 @@ public static class Server { // Default to 0.0 (no limit) public static final double DEFAULT_SERVER_CONSUMPTION_RATE_LIMIT = 0.0; + // Configs for server-side realtime ingestion OOM protection. These are consumed from the instance data manager + // config subset, so the user-facing property prefix is pinot.server.instance. + public static final String CONFIG_OF_SERVER_INGESTION_OOM_PROTECTION_MODE = + "ingestion.oom.protection.mode"; + public static final String DEFAULT_SERVER_INGESTION_OOM_PROTECTION_MODE = "DISABLE"; + public static final String CONFIG_OF_SERVER_INGESTION_OOM_PROTECTION_HEAP_USAGE_THROTTLE_THRESHOLD = + "ingestion.oom.protection.heapUsageThrottleThreshold"; + public static final double DEFAULT_SERVER_INGESTION_OOM_PROTECTION_HEAP_USAGE_THROTTLE_THRESHOLD = 0.95; + public static final String CONFIG_OF_SERVER_INGESTION_OOM_PROTECTION_HEAP_USAGE_RECOVERY_THRESHOLD = + "ingestion.oom.protection.heapUsageRecoveryThreshold"; + public static final double DEFAULT_SERVER_INGESTION_OOM_PROTECTION_HEAP_USAGE_RECOVERY_THRESHOLD = 0.90; + public static final String CONFIG_OF_SERVER_INGESTION_OOM_PROTECTION_CHECK_INTERVAL_MS = + "ingestion.oom.protection.checkIntervalMs"; + public static final long DEFAULT_SERVER_INGESTION_OOM_PROTECTION_CHECK_INTERVAL_MS = 1_000L; + public static final String CONFIG_OF_SERVER_INGESTION_OOM_PROTECTION_GC_INTERVAL_MS = Review Comment: Do we reset the GC timer when heap usage recovered? ########## pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerGauge.java: ########## @@ -94,6 +94,10 @@ public enum ServerGauge implements AbstractMetrics.Gauge { UPSERT_QUERYABLE_DOCS_IN_SNAPSHOT_COUNT("upsertQueryableDocIdsInSnapshot", false), REALTIME_INGESTION_OFFSET_LAG("offsetLag", false, "The difference between latest message offset and the last consumed message offset."), + REALTIME_INGESTION_OOM_PROTECTION_ACTIVE("boolean", true, + "Binary indicator (1 or 0) for whether the server-wide realtime ingestion OOM throttle is active."), + REALTIME_INGESTION_OOM_PROTECTION_HEAP_USAGE_PERCENT("percentage", true, Review Comment: The scope for heap usage shouldn't be under RT ingestion. We can emit it when reading heap usage -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
