Jackie-Jiang commented on code in PR #18715:
URL: https://github.com/apache/pinot/pull/18715#discussion_r3448931438
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/generator/BaseTaskGenerator.java:
##########
@@ -180,13 +180,18 @@ public List<SegmentZKMetadata>
getNonConsumingSegmentsZKMetadataForRealtimeTable
List<SegmentZKMetadata> selectedSegmentZKMetadataList = new ArrayList<>();
for (SegmentZKMetadata segmentZKMetadata : segmentZKMetadataList) {
String segmentName = segmentZKMetadata.getSegmentName();
+ Map<String, String> instanceStateMap =
idealState.getInstanceStateMap(segmentName);
if (idealStateSegments.contains(segmentName)
&& segmentZKMetadata.getStatus().isCompleted() // skip consuming
segments
- &&
!idealState.getInstanceStateMap(segmentName).containsValue(SegmentStateModel.CONSUMING))
{
+ && instanceStateMap != null
Review Comment:
We don't need this `null` check since we already checked
`idealStateSegments.contains(segmentName)`. No need to handle corrupted ideal
state
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
