Jackie-Jiang commented on code in PR #18413:
URL: https://github.com/apache/pinot/pull/18413#discussion_r3456180916
##########
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-hadoop/src/main/java/org/apache/pinot/plugin/ingestion/batch/hadoop/HadoopSegmentGenerationJobRunner.java:
##########
@@ -67,13 +67,10 @@
public class HadoopSegmentGenerationJobRunner extends Configured implements
IngestionJobRunner, Serializable {
private static final Logger LOGGER =
LoggerFactory.getLogger(HadoopSegmentGenerationJobRunner.class);
- public static final String SEGMENT_GENERATION_JOB_SPEC =
"segmentGenerationJobSpec";
+ // Kept for backward compatibility; callers should prefer
SegmentGenerationJobUtils.SEGMENT_GENERATION_JOB_SPEC
+ public static final String SEGMENT_GENERATION_JOB_SPEC =
SegmentGenerationJobUtils.SEGMENT_GENERATION_JOB_SPEC;
Review Comment:
This seems specific to Hadoop segment generation job. Suggest leaving it as
is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
