xiangfu0 commented on code in PR #18837:
URL: https://github.com/apache/pinot/pull/18837#discussion_r3463401258
##########
config/checkstyle.xml:
##########
@@ -357,4 +357,8 @@
<property name="format" value="StringUtils\.replace\("/>
<property name="message" value="StringUtils.replace() is deprecated. Use
Strings.CS.replace() instead."/>
</module>
+ <module name="RegexpSingleline">
Review Comment:
Also updated the agent docs/C7.12 to make the singleton exception stricter:
`Collections.singleton*` should only be used when an element/key/value argument
is intentionally null, since `List.of(null)`, `Set.of(null)`, and `Map.of(...)`
with null keys or values throw `NullPointerException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
