xiangfu0 commented on code in PR #18821:
URL: https://github.com/apache/pinot/pull/18821#discussion_r3466937024
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/data/manager/SegmentDataManager.java:
##########
@@ -82,6 +90,18 @@ public List<IndexSegment> getSegments() {
return Collections.emptyList();
}
+ /**
+ * The index segment(s) this manager exposes.
+ * Defaults to the single backing segment.
+ */
+ public List<IndexSegment> getReportableSegments() {
+ return List.of(getSegment());
+ }
Review Comment:
The new observability endpoints call `getReportableSegments()`, but this
default still returns only `getSegment()`. `DuoSegmentDataManager` only
overrides `getSegments()`, so during LLC commit the secondary live segment is
still invisible here and the size/index/row stats this PR is trying to fix
remain incomplete. Can this delegate to `getSegments()` when
`hasMultiSegments()` is true, or be overridden in `DuoSegmentDataManager`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
