xiangfu0 commented on code in PR #18833:
URL: https://github.com/apache/pinot/pull/18833#discussion_r3466938661
##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/FieldSpec.java:
##########
@@ -585,6 +613,16 @@ public ObjectNode toJsonObject() {
}
Review Comment:
This still does not round-trip the new metadata for legacy `TIME` columns.
`Schema.toJsonObject()` serializes `_timeFieldSpec` through
`TimeFieldSpec.toJsonObject()`, and that override never calls
`super.toJsonObject()`, so `fieldId` / `aliases` are silently dropped for time
columns even though this PR adds them generically on `FieldSpec`. Please thread
these fields through `TimeFieldSpec.toJsonObject()` (and add a schema-level
test) before merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
