deepthi912 commented on code in PR #18850:
URL: https://github.com/apache/pinot/pull/18850#discussion_r3475607548
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/MinionTaskUtils.java:
##########
@@ -441,42 +441,31 @@ public static long fromUTCString(String utcString) {
/**
* Get the validDocIdsType based on the upsertConfig and taskConfigs.
- * The default value is determined by whether delete is enabled in the
upsertConfig. If delete is enabled,
- * the default value is 'snapshot_with_delete', otherwise it is 'snapshot'.
- * If delete is enabled, we override the user-specified value to
'snapshot_with_delete' for backward compatibility
- * except when it is 'in_memory_with_delete'.
- * It also validates the combination of validDocIdsType, snapshot and
deleteRecordColumn.
+ * The default value is 'snapshot' It validates the combination of
validDocIdsType, snapshot and
Review Comment:
(nit) Can we change the comments format?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
