J-HowHuang opened a new pull request, #18851:
URL: https://github.com/apache/pinot/pull/18851

   ## Description
   A bad table config with unset environment variables could lead to exception 
when calling `ZKMetadataProvider#getTableConfig`, and essentially fails most of 
the table functions (e.g. realtime segment commit).
   
   ## Change
   Doing best effort to catch such bad config upon table config update. Some 
limitation though:
   1. Checks only one controller's environment, it could also become a bad 
config and throw exception if other pinot component or other controllers 
doesn't set the environment variable
   2. Doesn't help if someone unset the environment variable later
   
   Note: one is not supposed to update the table config first then set the 
environment variable, as the window between these two operation will break the 
table functionality.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to