spapin opened a new pull request, #18864: URL: https://github.com/apache/pinot/pull/18864
## Summary PR #18854 updated `controller.yml` to emit `numMinionSubtasks*` / `percentMinionSubtasks*` metrics with per-table+taskType labels (removing them from the global taskType-only rule). The Java side was not updated to match: - `ControllerGauge`: the 9 affected gauges were still marked `isGlobal=true` - `ControllerPrometheusMetricsTest`: still asserting the old global scoping for those gauges This PR aligns both to the new per-table scoping introduced by #18854. ## Changes - **`ControllerGauge.java`**: mark 9 subtask gauges as `isGlobal=false` — `NUM_MINION_SUBTASKS_WAITING`, `NUM_MINION_SUBTASKS_RUNNING`, `NUM_MINION_SUBTASKS_ERROR`, `NUM_MINION_SUBTASKS_UNKNOWN`, `NUM_MINION_SUBTASKS_DROPPED`, `NUM_MINION_SUBTASKS_TIMED_OUT`, `NUM_MINION_SUBTASKS_ABORTED`, `PERCENT_MINION_SUBTASKS_IN_QUEUE`, `PERCENT_MINION_SUBTASKS_IN_ERROR` - **`ControllerPrometheusMetricsTest.java`**: move the 9 gauges from `GLOBAL_GAUGES_ACCEPTING_TASKTYPE` into `GAUGES_ACCEPTING_TASKTYPE` (per-table scoped) ## Test plan - [x] `./mvnw -pl pinot-plugins/pinot-metrics/pinot-yammer -am -Dtest=YammerControllerPrometheusMetricsTest test` — passes (163 tests, 0 failures) - [x] `./mvnw checkstyle:check -pl pinot-common` — clean -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
