xiangfu0 commented on code in PR #18882:
URL: https://github.com/apache/pinot/pull/18882#discussion_r3498628983
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerMeter.java:
##########
@@ -27,6 +27,7 @@
*/
public enum ServerMeter implements AbstractMetrics.Meter {
QUERIES("queries", true),
+ QUERIES_ON_TABLE("queries", false),
Review Comment:
This new enum reuses the same table-level meter name (`queries`) as
`NUM_SECONDARY_QUERIES` and `NUM_SECONDARY_QUERIES_SCHEDULED`.
`AbstractMetrics` keys table meters as `<prefix><table>.<meterName>`, so all
three alias to the same `pinot.server.<table>.queries` series. Once
`InstanceRequestHandler` starts marking this on every request, tables with
secondary workloads will inflate the advertised table-level QPS signal because
the same query is marked again in `BinaryWorkloadScheduler`. This needs a
distinct meter name, or the secondary-workload meters need to move off
`queries` first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
