tarun11Mavani commented on code in PR #18643:
URL: https://github.com/apache/pinot/pull/18643#discussion_r3503495714
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java:
##########
@@ -415,6 +421,43 @@ private <K, V> Map<K, V> unmodifiable(Map<K, V> map) {
return map == null ? null : Collections.unmodifiableMap(map);
}
+ public void addOpenStructChildConfigs(SegmentMetadataImpl segmentMetadata) {
+ if (_indexConfigsByColName == null || _dirty) {
+ refreshIndexConfigs();
+ }
+ for (Map.Entry<String, ColumnMetadata> entry :
segmentMetadata.getColumnMetadataMap().entrySet()) {
+ String childColumn = entry.getKey();
+ if (!childColumn.contains(OpenStructNaming.SEPARATOR) ||
_indexConfigsByColName.containsKey(childColumn)) {
+ continue;
+ }
+ if (OpenStructNaming.isSparseColumn(childColumn)) {
+ continue;
+ }
+ String parentColumn = OpenStructNaming.parseParentColumn(childColumn);
+ FieldIndexConfigs parentConfigs =
_indexConfigsByColName.get(parentColumn);
+ if (parentConfigs == null) {
+ continue;
+ }
+ IndexConfig osConfig =
parentConfigs.getConfig(StandardIndexes.openStruct());
+ if (!(osConfig instanceof OpenStructIndexConfig)) {
+ continue;
+ }
+ OpenStructIndexConfig openStructConfig = (OpenStructIndexConfig)
osConfig;
+ String key = OpenStructNaming.parseKey(childColumn);
+ FieldConfig keyFieldConfig = openStructConfig.getValueFieldConfig(key);
+ if (keyFieldConfig == null) {
+ keyFieldConfig = openStructConfig.getDefaultValueFieldConfig();
+ }
+ FieldSpec childFieldSpec = entry.getValue().getFieldSpec();
+ boolean enableInverted =
openStructConfig.shouldEnableInvertedIndexForKey(key);
+ FieldIndexConfigs childConfigs = new FieldIndexConfigs.Builder(
+ FieldIndexConfigsUtil.fromFieldConfig(keyFieldConfig,
childFieldSpec))
+ .add(StandardIndexes.inverted(), enableInverted ?
IndexConfig.ENABLED : IndexConfig.DISABLED)
+ .build();
+ _indexConfigsByColName.put(childColumn, childConfigs);
Review Comment:
Fixed this. More details in
https://github.com/apache/pinot/pull/18643#discussion_r3503441561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
