noob-se7en commented on code in PR #18914:
URL: https://github.com/apache/pinot/pull/18914#discussion_r3529067665
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SegmentOnlineOfflineStateModelFactory.java:
##########
@@ -236,6 +236,15 @@ public void onBecomeDroppedFromOnline(Message message,
NotificationContext conte
@Transition(from = "ERROR", to = "OFFLINE")
public void onBecomeOfflineFromError(Message message, NotificationContext
context) {
_logger.info("SegmentOnlineOfflineStateModel.onBecomeOfflineFromError()
: {}", message);
+ try {
+ _instanceDataManager.offloadSegment(message.getResourceName(),
message.getPartitionName());
Review Comment:
I don't think this fix targets the ghost consumer problem mentioned in :
https://github.com/apache/pinot/issues/18867 (because error -> offline
transition will never occur in the linked issue's timeline). So we can separate
out this change from this PR and raise a new one as a different problem
statement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
