Vamsi-klu commented on PR #18343: URL: https://github.com/apache/pinot/pull/18343#issuecomment-4966078185
Checked the ordering and it holds up: `updateSegmentMetrics` runs before the guarded `updateTableSizeMetrics` in `processTable`, and both branches that return early (`idealState == null` and `!idealState.isEnabled()`) add to `_tablesToSkipSizeAggregation` before the guard reads it. `preprocess` builds a fresh `Context` each cycle, so the skip set never leaks across runs. Keeping `_disabledTables` as the narrower set so `DISABLED_TABLE_COUNT` isn't inflated by tables with a null IdealState is the right call, and `nullIdealStateTest` asserting that gauge stays 0 locks it in. And since `removeMetricsForTable` already fires in both branches, skipping the size call won't leave a stale gauge behind. I'm good with this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
