Vamsi-klu opened a new pull request, #19085: URL: https://github.com/apache/pinot/pull/19085
## Why Data engineers often build segments once and promote **staging → prod** (or clone tables) without rebuilding. The controller already prefers the request `tableName` over `segment.table.name` in metadata, but that override was under-documented and easy to misuse when the param was omitted (silent fallback to baked metadata). ## Impact - **Clear operator contract**: `-tableName` / query param **is** the override; metadata name is fallback only. - **Safer promotions**: log when request table ≠ metadata table so misroutes are visible. - **Test coverage** so the staging→prod path does not regress. - No forced tar rewrite required for the common REST/CLI upload path (ZK/placement already use request table). ## How - Document CLI `-tableName` as override of baked `segment.table.name`. - Log at info when upload overrides metadata table name. - Controller unit/integration-style test: upload with override succeeds against non-matching metadata name. ## Test plan - [x] `PinotSegmentUploadDownloadRestletResourceTest` (or related) override coverage. - [ ] `./mvnw -pl pinot-controller -am -Dtest=PinotSegmentUploadDownloadRestletResourceTest -Dsurefire.failIfNoSpecifiedTests=false test` ## Related closes: #5427 ## Reviewers Suggested: xiangfu0 --- ##### Was generative AI tooling used to co-author this PR? - [x] Yes — Grok Build (xAI) Generated-by: Grok Build (xAI) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
