xiangfu0 commented on PR #17182: URL: https://github.com/apache/pinot/pull/17182#issuecomment-5080358560
Closing this. `CROSS JOIN UNNEST` landed in the multi-stage engine in #17168 (with column pruning added in #18782) and covers this functionality, plus `WITH ORDINALITY` which this PR doesn't support. Adding a parallel implementation to the single-stage engine isn't the right investment given the direction toward MSE-by-default. Two gaps remain worth tracking separately: - ClickHouse-compatible `ARRAY JOIN` / `LEFT ARRAY JOIN` syntax, implemented as a parser-level desugaring to `CROSS JOIN UNNEST` so it runs on MSE. - Outer unnest semantics (keep rows whose array is empty) — `RelToPlanNodeConverter#convertLogicalCorrelate` currently ignores the correlate's join type. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
