xiangfu0 commented on PR #18875: URL: https://github.com/apache/pinot/pull/18875#issuecomment-5101846044
### Scalar UDFs split out into #19091 The UUID scalar functions and their multi-stage UDF wrappers have been moved out of this PR into **#19091**, so they can be reviewed and merged in parallel with the partitioning work. **Moved to #19091** (15 files): | Area | Contents | |---|---| | `pinot-common` | `function/scalar/uuid/` — `IsUuidScalarFunction`, `ToUuidScalarFunction`, `UuidConversionFunctions`, `AbstractStringOrBytesUuidFunction` | | `pinot-common` (test) | `UuidConversionFunctionsTest`, the `StringFunctionsTest` mixed-case case | | `pinot-query-runtime` | the nine `*Udf` wrappers | **Still here** — `UuidPartitionFunction`, the `PartitionerFactory` / `TableConfigPartitioner` / `SegmentMapper` wiring, `PartitionFunctionTest`, and the `UUID_ARRAY` entries for the array scalar functions. #19091 is based directly on `master` and depends only on already-merged work (`UuidUtils` from #18869, `ColumnDataType.UUID` from #18871, and `SqlTypeName.UUID` from Calcite 1.42), so it does **not** need this stack. Also in this push: - Replaced an inline fully-qualified `org.apache.pinot.spi.utils.UuidUtils.toBytes(...)` in `PartitionFunctionTest` with a normal import. - Converted this layer's new Javadoc in `PartitionerFactory` to `///` markdown doc comments, matching `UuidPartitionFunction` and `TableConfigPartitioner`. Verified after the split: `pinot-common`, `pinot-core`, `pinot-query-planner` and `pinot-query-runtime` all `test-compile` cleanly without the UDF files, `PartitionFunctionTest` passes 20/20, and spotless / checkstyle / license are clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
