Jackie-Jiang commented on PR #19111: URL: https://github.com/apache/pinot/pull/19111#issuecomment-5124236644
> I am thinking to compute min/max on demand in MutableNoDictColumnStatistics — when the mutable segment reports null (aggregated columns skip min/max tracking since the value mutates), scan the sealed forward index once (same pass isSorted() already does), before the BitSliced creator is constructed. > > This adds one extra O(numDocs) scan per such column at seal time. Will this be OK? Yes. That is the overhead we need to pay in order to add range index. We should also check how RangeIndexHandler handles null min/max value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
