pri1712 commented on code in PR #19011:
URL: https://github.com/apache/pinot/pull/19011#discussion_r3708943173
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -464,4 +480,107 @@ protected void onQueryFinish(long requestId) {
protected boolean isQueryCancellationEnabled() {
return _enableQueryCancellation;
}
+
+ /// Appends a where clause to the query to filter out of retention data if
SKIP_OUT_OF_RETENTION_VALUES is
+ /// set to True in query Options.
+ /// @param sqlNodeAndOptions
+ private void applySkipOutOfRetentionValuesIfNeeded(SqlNodeAndOptions
sqlNodeAndOptions) {
+ Map<String, String> options = sqlNodeAndOptions.getOptions();
+ if
(!Boolean.parseBoolean(options.get(QueryOptionKey.SKIP_OUT_OF_RETENTION_VALUES)))
{
+ return;
+ }
+ SqlNode sqlNode = sqlNodeAndOptions.getSqlNode();
+ if (sqlNode == null) {
+ return;
+ }
+
+ // Resolve the inner SqlSelect, unwrapping SqlOrderBy if needed.
+ // SqlWith (CTEs) and other statement types are not supported.
+ SqlSelect sqlSelect;
Review Comment:
to scope this out better, what do we want to support as a part of this
feature? is it just simple single table queries or are CTEs and joins in scope?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
