Jackie-Jiang commented on code in PR #19155:
URL: https://github.com/apache/pinot/pull/19155#discussion_r3715025898
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java:
##########
@@ -202,6 +204,9 @@ public static Literal getLiteral(@Nullable Object object) {
if (object instanceof Timestamp) {
return getLiteral(((Timestamp) object).getTime());
}
+ if (object instanceof UUID) {
Review Comment:
(minor) Put this after `byte[]`
##########
pinot-common/src/main/java/org/apache/pinot/common/request/context/LiteralContext.java:
##########
@@ -174,6 +174,9 @@ private static PinotDataType getPinotDataType(DataType
type, @Nullable Object va
return PinotDataType.BIG_DECIMAL;
case STRING:
return singleValue ? PinotDataType.STRING : PinotDataType.STRING_ARRAY;
+ case UUID:
Review Comment:
(minor) Consider adding a TODO for this method to revisit MV BOOLEAN,
BIG_DECIMAL, BYTES, UUID
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
