Jackie-Jiang commented on code in PR #18427:
URL: https://github.com/apache/pinot/pull/18427#discussion_r3717058511
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -1229,6 +1229,16 @@ protected void removeDocId(IndexSegment segment, int
docId) {
trackUpdatedSegmentsSinceLastSnapshot(segment);
}
+ protected void emitUpsertMetrics(RecordInfo recordInfo, boolean isNewKey) {
+ if (recordInfo.isDeleteRecord()) {
Review Comment:
Do we want to track the case where deletion is trying to delete a
non-existing key?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
