Jackie-Jiang commented on code in PR #19158:
URL: https://github.com/apache/pinot/pull/19158#discussion_r3717219822
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/MinStringAggregationFunction.java:
##########
@@ -93,7 +93,7 @@ public void aggregateGroupBySV(int length, int[]
groupKeyArray, GroupByResultHol
String currentMin = groupByResultHolder.getResult(groupKey);
if (currentMin == null || value.compareTo(currentMin) < 0) {
groupByResultHolder.setValueForKey(groupKey, value);
- }
+ }
Review Comment:
Fixed. The `if` closing brace now sits at 8, aligned with the `if` it closes.
This and the three sibling comments were all the same defect: a scripted
edit earlier in this change dropped the leading whitespace on a handful of
lines. Verified against checkstyle locally before pushing.
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/MaxStringAggregationFunction.java:
##########
@@ -94,7 +94,7 @@ public void aggregateGroupBySV(int length, int[]
groupKeyArray, GroupByResultHol
String currentMax = groupByResultHolder.getResult(groupKey);
if (currentMax == null || value.compareTo(currentMax) > 0) {
groupByResultHolder.setValueForKey(groupKey, value);
- }
+ }
Review Comment:
Fixed, same as the `MinStringAggregationFunction` case — the `if` closing
brace is now at 8.
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/MinAggregationFunction.java:
##########
@@ -301,7 +302,7 @@ protected void aggregateMVGroupByMV(BlockValSet
blockValSet, int length, int[][]
if (_nullHandlingEnabled) {
forEachNotNull(length, blockValSet, (from, to) -> {
- for (int i = from; i < to; i++) {
+ for (int i = from; i < to; i++) {
Double min = null;
for (double value : valuesArray[i]) {
Review Comment:
Fixed. The inner `for` was at 10 where the lambda body belongs at 8; its own
body and closing brace were already correct, so only that line moved.
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/MaxAggregationFunction.java:
##########
@@ -301,7 +302,7 @@ protected void aggregateMVGroupByMV(BlockValSet
blockValSet, int length, int[][]
if (_nullHandlingEnabled) {
forEachNotNull(length, blockValSet, (from, to) -> {
- for (int i = from; i < to; i++) {
+ for (int i = from; i < to; i++) {
Double max = null;
for (double value : valuesArray[i]) {
Review Comment:
Fixed, same as the `MinAggregationFunction` case — the inner `for` moved
from 10 to 8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
