xiangfu0 commented on PR #19118: URL: https://github.com/apache/pinot/pull/19118#issuecomment-5186969384
Addressed in 4af0a57692. - Pinot-backed segment rewrites now materialize and carry the source `$creationTime` as a physical LONG column through both record-reader and columnar paths. - CONCAT preserves each record value; ROLLUP and DEDUP exclude `$creationTime` from grouping/equality keys and retain the maximum source value when rows collapse. - The refresh-task E2E rebuilds a legacy segment with output metadata time `3000`, verifies its physical row value remains `1000`, and verifies the newer pushed row still wins upsert. - Added all-merge-mode coverage plus a guard against custom readers mislabeled as PINOT. Validated locally with the focused core tests (44 tests), columnar/segment-reader tests (6 tests), `RefreshSegmentUpsertMinionTest`, the JDK 25 reactor compilation, Spotless, Checkstyle, and license checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
