xiangfu0 commented on PR #18681: URL: https://github.com/apache/pinot/pull/18681#issuecomment-5189207823
Local patch follow-up (still not pushed to the contributor branch): - Residual validation now treats each projected GROUP BY expression as an atomic key. A bare source identifier nested inside a scalar key, such as `UniqueCarrier` under `UPPER(UniqueCarrier)`, rejects the MV instead of leaking the unavailable raw column into the rewritten query. - Added three strategy regressions covering the unsafe raw identifier, the exact scalar expression, and an aliased direct grouping key. - Extended `MaterializedViewClusterIntegrationTest` with both a positive scalar re-aggregation case and a negative full-broker fallback case, each compared with rewrite disabled. Local JDK 25 validation: - `AggregationSubsumptionStrategyTest`: 48 passed - `MaterializedViewClusterIntegrationTest`: 12 passed; full 63-module reactor succeeded - Spotless, Checkstyle, license format/check: passed for both affected modules - Warning-enabled compile: passed with no warnings in the changed files - Final eight-domain review: no remaining code or test findings The PR description/commit-body rationale and `Co-authored-by: Cursor` trailer still need maintainer/author cleanup. I have not amended, force-pushed, committed, or pushed anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
