tarun11Mavani commented on code in PR #19154: URL: https://github.com/apache/pinot/pull/19154#discussion_r3723526934
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/openstruct/SparseKeyDataSource.java: ########## @@ -0,0 +1,254 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.segment.index.openstruct; + +import com.fasterxml.jackson.databind.JsonNode; +import java.io.IOException; +import java.math.BigDecimal; +import java.util.Map; +import java.util.Set; +import java.util.function.Function; +import javax.annotation.Nullable; +import org.apache.pinot.segment.local.segment.index.datasource.BaseDataSource; +import org.apache.pinot.segment.spi.Constants; +import org.apache.pinot.segment.spi.datasource.DataSourceMetadata; +import org.apache.pinot.segment.spi.index.StandardIndexes; +import org.apache.pinot.segment.spi.index.column.ColumnIndexContainer; +import org.apache.pinot.segment.spi.index.reader.ForwardIndexReader; +import org.apache.pinot.segment.spi.index.reader.ForwardIndexReaderContext; +import org.apache.pinot.segment.spi.index.reader.NullValueVectorReader; +import org.apache.pinot.segment.spi.partition.PartitionFunction; +import org.apache.pinot.spi.data.FieldSpec; +import org.apache.pinot.spi.data.FieldSpec.DataType; +import org.roaringbitmap.buffer.ImmutableRoaringBitmap; +import org.roaringbitmap.buffer.MutableRoaringBitmap; + + +/// Virtual per-key DataSource for a sparse OPEN_STRUCT key. Parses the blob per doc via +/// the shared [OpenStructSparseBlobReader], coerces to the resolved stored type. No dictionary. +/// Null vector built lazily (one blob scan, memoized). +public class SparseKeyDataSource extends BaseDataSource { + private final FieldSpec _fieldSpec; + + public SparseKeyDataSource(FieldSpec resolvedChildSpec, OpenStructSparseBlobReader blobReader) { + super(new SparseKeyMetadata(resolvedChildSpec, blobReader.getNumDocs()), + new ColumnIndexContainer.FromMap(Map.of( + StandardIndexes.forward(), + new SparseKeyForwardIndexReader(resolvedChildSpec.getName(), + resolvedChildSpec.getDataType().getStoredType(), blobReader), + StandardIndexes.nullValueVector(), + new LazyPresenceNullVector(resolvedChildSpec.getName(), blobReader)))); + _fieldSpec = resolvedChildSpec; + } + + public FieldSpec getFieldSpec() { + return _fieldSpec; + } + + static class SparseKeyForwardIndexReader implements ForwardIndexReader<ForwardIndexReaderContext> { + private final String _key; + private final DataType _storedType; + private final OpenStructSparseBlobReader _blob; + + SparseKeyForwardIndexReader(String key, DataType storedType, OpenStructSparseBlobReader blob) { + _key = key; + _storedType = storedType; + _blob = blob; + } + + @Override + public boolean isDictionaryEncoded() { + return false; + } + + @Override + public boolean isSingleValue() { + return true; + } + + @Override + public DataType getStoredType() { + return _storedType; + } + + @Override + public ForwardIndexReaderContext createContext() { + return _blob.createBlobContext(); + } + + @Nullable + private JsonNode valueNode(int docId, ForwardIndexReaderContext context) { + JsonNode node = _blob.getValue(docId, _key, context); + return node == null || node.isNull() ? null : node; + } + + private <T> T orDefault(int docId, ForwardIndexReaderContext context, Function<JsonNode, T> map, T defaultValue) { + JsonNode node = valueNode(docId, context); + return node == null ? defaultValue : map.apply(node); + } + + @Override + public int getInt(int docId, ForwardIndexReaderContext context) { + return orDefault(docId, context, JsonNode::asInt, FieldSpec.DEFAULT_DIMENSION_NULL_VALUE_OF_INT); + } + + @Override + public long getLong(int docId, ForwardIndexReaderContext context) { + return orDefault(docId, context, JsonNode::asLong, FieldSpec.DEFAULT_DIMENSION_NULL_VALUE_OF_LONG); + } + + @Override + public float getFloat(int docId, ForwardIndexReaderContext context) { + return orDefault(docId, context, node -> (float) node.asDouble(), + FieldSpec.DEFAULT_DIMENSION_NULL_VALUE_OF_FLOAT); + } + + @Override + public double getDouble(int docId, ForwardIndexReaderContext context) { + return orDefault(docId, context, JsonNode::asDouble, FieldSpec.DEFAULT_DIMENSION_NULL_VALUE_OF_DOUBLE); + } + + @Override + public BigDecimal getBigDecimal(int docId, ForwardIndexReaderContext context) { + return orDefault(docId, context, node -> new BigDecimal(node.asText()), + FieldSpec.DEFAULT_DIMENSION_NULL_VALUE_OF_BIG_DECIMAL); + } + + @Override + public String getString(int docId, ForwardIndexReaderContext context) { + return orDefault(docId, context, JsonNode::asText, FieldSpec.DEFAULT_DIMENSION_NULL_VALUE_OF_STRING); + } + + @Override + public byte[] getBytes(int docId, ForwardIndexReaderContext context) { Review Comment: Good point. Fixed it. ########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/openstruct/SparseKeyDataSource.java: ########## @@ -0,0 +1,254 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.segment.index.openstruct; + +import com.fasterxml.jackson.databind.JsonNode; +import java.io.IOException; +import java.math.BigDecimal; +import java.util.Map; +import java.util.Set; +import java.util.function.Function; +import javax.annotation.Nullable; +import org.apache.pinot.segment.local.segment.index.datasource.BaseDataSource; +import org.apache.pinot.segment.spi.Constants; +import org.apache.pinot.segment.spi.datasource.DataSourceMetadata; +import org.apache.pinot.segment.spi.index.StandardIndexes; +import org.apache.pinot.segment.spi.index.column.ColumnIndexContainer; +import org.apache.pinot.segment.spi.index.reader.ForwardIndexReader; +import org.apache.pinot.segment.spi.index.reader.ForwardIndexReaderContext; +import org.apache.pinot.segment.spi.index.reader.NullValueVectorReader; +import org.apache.pinot.segment.spi.partition.PartitionFunction; +import org.apache.pinot.spi.data.FieldSpec; +import org.apache.pinot.spi.data.FieldSpec.DataType; +import org.roaringbitmap.buffer.ImmutableRoaringBitmap; +import org.roaringbitmap.buffer.MutableRoaringBitmap; + + +/// Virtual per-key DataSource for a sparse OPEN_STRUCT key. Parses the blob per doc via +/// the shared [OpenStructSparseBlobReader], coerces to the resolved stored type. No dictionary. +/// Null vector built lazily (one blob scan, memoized). +public class SparseKeyDataSource extends BaseDataSource { + private final FieldSpec _fieldSpec; + + public SparseKeyDataSource(FieldSpec resolvedChildSpec, OpenStructSparseBlobReader blobReader) { + super(new SparseKeyMetadata(resolvedChildSpec, blobReader.getNumDocs()), + new ColumnIndexContainer.FromMap(Map.of( + StandardIndexes.forward(), + new SparseKeyForwardIndexReader(resolvedChildSpec.getName(), + resolvedChildSpec.getDataType().getStoredType(), blobReader), + StandardIndexes.nullValueVector(), + new LazyPresenceNullVector(resolvedChildSpec.getName(), blobReader)))); + _fieldSpec = resolvedChildSpec; + } + + public FieldSpec getFieldSpec() { + return _fieldSpec; + } + + static class SparseKeyForwardIndexReader implements ForwardIndexReader<ForwardIndexReaderContext> { + private final String _key; + private final DataType _storedType; + private final OpenStructSparseBlobReader _blob; + + SparseKeyForwardIndexReader(String key, DataType storedType, OpenStructSparseBlobReader blob) { + _key = key; + _storedType = storedType; + _blob = blob; + } + + @Override + public boolean isDictionaryEncoded() { + return false; + } + + @Override + public boolean isSingleValue() { + return true; + } + + @Override + public DataType getStoredType() { + return _storedType; + } + + @Override + public ForwardIndexReaderContext createContext() { + return _blob.createBlobContext(); + } + + @Nullable + private JsonNode valueNode(int docId, ForwardIndexReaderContext context) { + JsonNode node = _blob.getValue(docId, _key, context); + return node == null || node.isNull() ? null : node; + } + + private <T> T orDefault(int docId, ForwardIndexReaderContext context, Function<JsonNode, T> map, T defaultValue) { + JsonNode node = valueNode(docId, context); + return node == null ? defaultValue : map.apply(node); + } + + @Override + public int getInt(int docId, ForwardIndexReaderContext context) { Review Comment: Dense doesn't coerce mismatches differently and neither tier ever sees them. Your example: `convert("abc", STRING)` into INT throws, so `addMap` bumps `_coercionFailures`, drops the doc from `_presenceBitmaps` and stores nothing. Dense then writes the default and marks the null vector; sparse omits the key so `valueNode` returns null and `orDefault` gives `DEFAULT_DIMENSION_NULL_VALUE_OF_INT`. Same value, same nullability. Added a test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
