deepthi912 commented on code in PR #19153:
URL: https://github.com/apache/pinot/pull/19153#discussion_r3725563269
##########
pinot-core/src/main/java/org/apache/pinot/core/startree/StarTreeUtils.java:
##########
@@ -335,12 +338,25 @@ private static PredicateEvaluator
getPredicateEvaluator(IndexSegment indexSegmen
}
for (Pair<Predicate, PredicateEvaluator> pair :
predicatesEvaluatorMapping) {
if (pair.getKey() == predicate) {
- return pair.getValue();
+ return toDictionaryBased(pair.getValue(), predicate, dataSource);
}
}
return null;
}
+ /// Star-tree traversal reads dictionary ids; a raw-value evaluator (built
when the forward index is RAW and no
+ /// dict-consuming scan operator was available) would throw from
`getMatchingDictIds` / `applySV(int)`. Rebuild
+ /// against the segment dictionary when needed.
+ @VisibleForTesting
+ static PredicateEvaluator toDictionaryBased(PredicateEvaluator evaluator,
Predicate predicate,
+ DataSource dataSource) {
+ if (!(evaluator instanceof BaseRawValueBasedPredicateEvaluator)) {
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
